Code review comment for lp:~shnatsel/unattended-upgrades/plymouth-message-fix

Revision history for this message
Colin Watson (cjwatson) wrote :

Thanks for your suggestion.

I'm thoroughly confused about this. Making this script setuid is definitely not going to be allowed - it should just be started with the proper privileges in the first place. However, as far as I can tell, all the code paths that start unattended-upgrade-shutdown do so as root, and plymouthd explicitly refuses messages from non-root users. So I don't quite understand what's going on here, and how dropping to a non-root user might help.

review: Needs Information

« Back to merge proposal