Merge lp:~shnatsel/unattended-upgrades/plymouth-message-fix into lp:~ubuntu-core-dev/unattended-upgrades/ubuntu

[Sergey "Shnatsel" Davidoff]

Partially fixed sending messages to Plymouth (race condition still not handled)

[Colin Watson (cjwatson)]

Thanks for your suggestion.

I'm thoroughly confused about this. Making this script setuid is definitely not going to be allowed - it should just be started with the proper privileges in the first place. However, as far as I can tell, all the code paths that start unattended-upgrade-shutdown do so as root, and plymouthd explicitly refuses messages from non-root users. So I don't quite understand what's going on here, and how dropping to a non-root user might help.

review: Needs Information

[Vish (vish)]

Sergey "Shnatsel" Davidoff: Pls update the branch, push changes to this branch and comment on the merge *here*. That's usually how review/comment works for branches.
Colin is not subscribed to the bug(i dont see any other team subscriptions where he would be notified either), so he would not be aware of the changes you have made if you comment on the bug alone..

[Sergey "Shnatsel" Davidoff (shnatsel)]

Vish, thank you very much for your help!
I've tested this all again and now everything works even without the SUID and changing the owner to daemon.
It used to work for me in X11 Plymouth renderer if I started Plymouth daemon as root and passed messages to it, also as root, but it didn't work on shutdown. I chowned it to daemon and added suid bit, and the messages appeared on shutdown too. I switched permissions back and it still works... I'm totally confused with all those Upstart and Plymouth permissions now.

review: Disapprove

Unmerged revisions

154. By Sergey "Shnatsel" Davidoff on 2010-12-22

fixed sending messages to Plymouth (except for race condition)

=== modified file 'debian/postinst'
--- debian/postinst	2010-11-18 08:34:41 +0000
+++ debian/postinst	2010-12-22 16:37:00 +0000
@@ -33,6 +33,10 @@
 	    ucf --three-way --debconf-ok "$NEWFILE" "$CONFIG"
 	    ucfr unattended-upgrades "$CONFIG"
         fi
+	
+	# Fix sending messages to Plymouth
+	chown daemon:daemon /usr/share/unattended-upgrades/unattended-upgrade-shutdown
+	chmod u+s /usr/share/unattended-upgrades/unattended-upgrade-shutdown
 
         # Recover from incorrect init.d script header in versions < 0.64
         if dpkg --compare-versions "$2" lt "0.64" \