Code review comment for lp:~jameinel/juju-core/login-returns-env-tag

Revision history for this message
Andrew Wilkins (axwalk) wrote :

https://codereview.appspot.com/101760046/diff/40001/state/apiserver/login_test.go
File state/apiserver/login_test.go (right):

https://codereview.appspot.com/101760046/diff/40001/state/apiserver/login_test.go#newcode519
state/apiserver/login_test.go:519:
On 2014/06/01 09:53:31, jameinel wrote:
> On 2014/05/29 03:59:25, axw wrote:
> > func (s *loginSuite) TestLoginAcceptsEmptyEnvironTag(c *gc.C) {
> > ...
> > }
> >
> > ?

> If you look, "TestLoginReportsEnvironTag" explicitly passes
EnvironTag:"" which
> is the test you're looking for. Would you prefer a different name?

Sorry, don't know how I missed that. That's fine.

https://codereview.appspot.com/101760046/

« Back to merge proposal