lp:~jameinel/juju-core/login-returns-env-tag

Branch merges

Propose for merging

No branches dependent on this one.

On hold for merging into lp:~go-bot/juju-core/trunk

Juju Engineering: Pending requested 2014-05-27

Diff: 851 lines (+402/-41)

14 files modified

environs/configstore/disk.go (+5/-2)
environs/configstore/interface.go (+4/-0)
environs/configstore/interface_test.go (+6/-4)
juju/api.go (+42/-14)
juju/apiconn_test.go (+139/-3)
juju/mock_test.go (+5/-0)
state/api/apiclient.go (+14/-1)
state/api/apiclient_test.go (+22/-0)
state/api/params/params.go (+6/-4)
state/api/state.go (+6/-4)
state/api/state_test.go (+48/-0)
state/apiserver/admin.go (+21/-1)
state/apiserver/common/errors.go (+2/-0)
state/apiserver/login_test.go (+82/-8)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

2802. By John A Meinel on 2014-05-27

clarify in the comments that we are explicitly testing the case where EnvironTag is empty.

2801. By John A Meinel on 2014-05-27

clean up the code so that we only store EnvironUUID and just talk about EnvironTag in the api calls

2800. By John A Meinel on 2014-05-27

Fix another edge case.

Our test suite doesn't always have APIHostPorts available, because we don't
always have a machine-0. In those cases, we can get an EnvironTag but not
have any addresses to connect to. We don't want to end up setting the
connection addresses to the empty list, and make it hard to actually
connect to the environment.
Add a test, move where we set addrs to only set it when they have changed.

2799. By John A Meinel on 2014-05-27

Fixup the APIServer tests now that Login takes the extra argument

2798. By John A Meinel on 2014-05-27

Test that Open and Login will pass the EnvironTag when requested.

2797. By John A Meinel on 2014-05-27

update another environs/configstore test for the new tag

2796. By John A Meinel on 2014-05-26

Thread the EnvironTag code through the testing mocks at least.
The 'juju' test suite is happy.

2795. By John A Meinel on 2014-05-26

Start working on threading EnvironTag through all the apis, not quite working yet.

2794. By John A Meinel on 2014-05-26

rename Environ to EnvironTag.

2793. By John A Meinel on 2014-05-26

Admin.Login accepts environ tags, and will give you a valid error when it doesn't know about the UUID you are requesting.