Space after Bible book name auto-completion is missing
Bug #1678292 reported by
Azaziah
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenLP |
Fix Committed
|
Low
|
Azaziah | ||
Bug Description
If the user uses Bible book name auto-completion in
the Bible search, the space after the book name is missing.
Example of searching Psalms 23:
Ps > Psalm23
Thus the user needs to add the space manually.
(The search works without the space as well but it would be better visually)
this works as intended in 2.4.6 but not in trunk rev 2730.
The added space should not be visible in the book name on footer.
Edit: Something broke it in rev 2722 (Bible media item
refactors), it works in 2721.
http://
Trunk revision 2730, Windows 10
(Works in 2.4.6)
Related branches
lp:~suutari-olli/openlp/azaziah-fixes-and-improvements
- Tim Bentley: Approve
- Raoul Snyman: Approve
-
Diff: 798 lines (+123/-66)49 files modifiedopenlp/core/common/settings.py (+5/-1)
openlp/core/lib/searchedit.py (+2/-2)
openlp/core/lib/ui.py (+1/-0)
openlp/core/ui/__init__.py (+3/-3)
openlp/core/ui/aboutform.py (+2/-1)
openlp/core/ui/filerenameform.py (+2/-2)
openlp/core/ui/firsttimelanguageform.py (+2/-1)
openlp/core/ui/formattingtagform.py (+2/-1)
openlp/core/ui/lib/wizard.py (+5/-2)
openlp/core/ui/maindisplay.py (+1/-1)
openlp/core/ui/pluginform.py (+2/-1)
openlp/core/ui/printserviceform.py (+2/-2)
openlp/core/ui/projector/editform.py (+2/-1)
openlp/core/ui/projector/sourceselectform.py (+4/-2)
openlp/core/ui/serviceitemeditform.py (+2/-2)
openlp/core/ui/servicenoteform.py (+2/-2)
openlp/core/ui/settingsform.py (+2/-1)
openlp/core/ui/shortcutlistform.py (+2/-1)
openlp/core/ui/starttimeform.py (+2/-2)
openlp/plugins/alerts/forms/alertform.py (+2/-2)
openlp/plugins/bibles/bibleplugin.py (+1/-1)
openlp/plugins/bibles/forms/booknameform.py (+2/-1)
openlp/plugins/bibles/forms/editbibleform.py (+2/-1)
openlp/plugins/bibles/forms/languageform.py (+2/-1)
openlp/plugins/bibles/lib/__init__.py (+2/-2)
openlp/plugins/bibles/lib/mediaitem.py (+3/-1)
openlp/plugins/custom/customplugin.py (+1/-1)
openlp/plugins/custom/forms/editcustomform.py (+2/-1)
openlp/plugins/custom/forms/editcustomslideform.py (+2/-1)
openlp/plugins/images/forms/addgroupform.py (+2/-1)
openlp/plugins/images/forms/choosegroupform.py (+2/-1)
openlp/plugins/media/forms/mediaclipselectorform.py (+2/-1)
openlp/plugins/songs/forms/authorsform.py (+2/-1)
openlp/plugins/songs/forms/duplicatesongremovalform.py (+3/-0)
openlp/plugins/songs/forms/editsongform.py (+2/-1)
openlp/plugins/songs/forms/editverseform.py (+2/-1)
openlp/plugins/songs/forms/mediafilesform.py (+2/-1)
openlp/plugins/songs/forms/songbookform.py (+2/-1)
openlp/plugins/songs/forms/songmaintenancedialog.py (+1/-1)
openlp/plugins/songs/forms/songmaintenanceform.py (+2/-1)
openlp/plugins/songs/forms/songselectform.py (+2/-1)
openlp/plugins/songs/forms/topicsform.py (+2/-1)
openlp/plugins/songs/songsplugin.py (+1/-1)
openlp/plugins/songusage/forms/songusagedeleteform.py (+1/-1)
openlp/plugins/songusage/forms/songusagedetailform.py (+2/-1)
tests/functional/openlp_core_ui/test_maindisplay.py (+16/-1)
tests/functional/openlp_plugins/bibles/test_lib.py (+4/-1)
tests/functional/openlp_plugins/bibles/test_mediaitem.py (+7/-7)
tests/interfaces/openlp_core_lib/test_searchedit.py (+2/-2)
| description: | updated |
| description: | updated |
| Changed in openlp: | |
| importance: | Undecided → Wishlist |
| Changed in openlp: | |
| importance: | Wishlist → Undecided |
| description: | updated |
| description: | updated |
| summary: |
- Add space after Bible book name auto-completion + Space after Bible book name auto-completion is missing |
| Changed in openlp: | |
| importance: | Undecided → Low |
Revision history for this message
| Phill (phill-ridout) wrote | #1 |
Revision history for this message
| Azaziah (suutari-olli) wrote | #2 |
| description: | updated |
| Changed in openlp: | |
| status: | New → In Progress |
| assignee: | nobody → Azaziah (suutari-olli) |
| Changed in openlp: | |
| status: | In Progress → Fix Committed |
| milestone: | none → 2.5.1 |
To post a comment you must log in.
I would disagree that this is a bug. It works the same way as other auto completers do, just try few examples in OpenLP and Google. I think its best to emulate the way others do it from a usability point of view.