lp:~suutari-olli/openlp/azaziah-fixes-and-improvements

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:openlp at revision 2749

Tim Bentley: Approve on 2017-06-08

Raoul Snyman: Approve on 2017-06-08

Diff: 798 lines (+123/-66)

49 files modified

openlp/core/common/settings.py (+5/-1)
openlp/core/lib/searchedit.py (+2/-2)
openlp/core/lib/ui.py (+1/-0)
openlp/core/ui/__init__.py (+3/-3)
openlp/core/ui/aboutform.py (+2/-1)
openlp/core/ui/filerenameform.py (+2/-2)
openlp/core/ui/firsttimelanguageform.py (+2/-1)
openlp/core/ui/formattingtagform.py (+2/-1)
openlp/core/ui/lib/wizard.py (+5/-2)
openlp/core/ui/maindisplay.py (+1/-1)
openlp/core/ui/pluginform.py (+2/-1)
openlp/core/ui/printserviceform.py (+2/-2)
openlp/core/ui/projector/editform.py (+2/-1)
openlp/core/ui/projector/sourceselectform.py (+4/-2)
openlp/core/ui/serviceitemeditform.py (+2/-2)
openlp/core/ui/servicenoteform.py (+2/-2)
openlp/core/ui/settingsform.py (+2/-1)
openlp/core/ui/shortcutlistform.py (+2/-1)
openlp/core/ui/starttimeform.py (+2/-2)
openlp/plugins/alerts/forms/alertform.py (+2/-2)
openlp/plugins/bibles/bibleplugin.py (+1/-1)
openlp/plugins/bibles/forms/booknameform.py (+2/-1)
openlp/plugins/bibles/forms/editbibleform.py (+2/-1)
openlp/plugins/bibles/forms/languageform.py (+2/-1)
openlp/plugins/bibles/lib/__init__.py (+2/-2)
openlp/plugins/bibles/lib/mediaitem.py (+3/-1)
openlp/plugins/custom/customplugin.py (+1/-1)
openlp/plugins/custom/forms/editcustomform.py (+2/-1)
openlp/plugins/custom/forms/editcustomslideform.py (+2/-1)
openlp/plugins/images/forms/addgroupform.py (+2/-1)
openlp/plugins/images/forms/choosegroupform.py (+2/-1)
openlp/plugins/media/forms/mediaclipselectorform.py (+2/-1)
openlp/plugins/songs/forms/authorsform.py (+2/-1)
openlp/plugins/songs/forms/duplicatesongremovalform.py (+3/-0)
openlp/plugins/songs/forms/editsongform.py (+2/-1)
openlp/plugins/songs/forms/editverseform.py (+2/-1)
openlp/plugins/songs/forms/mediafilesform.py (+2/-1)
openlp/plugins/songs/forms/songbookform.py (+2/-1)
openlp/plugins/songs/forms/songmaintenancedialog.py (+1/-1)
openlp/plugins/songs/forms/songmaintenanceform.py (+2/-1)
openlp/plugins/songs/forms/songselectform.py (+2/-1)
openlp/plugins/songs/forms/topicsform.py (+2/-1)
openlp/plugins/songs/songsplugin.py (+1/-1)
openlp/plugins/songusage/forms/songusagedeleteform.py (+1/-1)
openlp/plugins/songusage/forms/songusagedetailform.py (+2/-1)
tests/functional/openlp_core_ui/test_maindisplay.py (+16/-1)
tests/functional/openlp_plugins/bibles/test_lib.py (+4/-1)
tests/functional/openlp_plugins/bibles/test_mediaitem.py (+7/-7)
tests/interfaces/openlp_core_lib/test_searchedit.py (+2/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1639860: Close button is disabled in numerous windows	Low	Fix Committed
Bug #1652559: Find duplicates wizard does not reset cursor if closed from "x" instead of "cancel" button and causes traceback on exit	Low	Fix Committed
Bug #1666272: Linked audio "next" button results in traceback	Low	Fix Committed
Bug #1678292: Space after Bible book name auto-completion is missing	Low	Fix Committed
Bug #1694732: wizard sub title does not wrap	Low	Fix Committed
Bug #1695268: Bibles plugin fails to load due to invalid "last search type" value	High	Fix Committed

Link a bug report

Related blueprints

2765. By Azaziah on 2017-06-05

- Added a test for checking that next calls the next playlist item

2764. By Azaziah on 2017-06-05

Value of old last used Bible search type is no longer transferred to settings since it's invalid and gets replaced on boot anyways.

2763. By Azaziah on 2017-06-05

- Fixed over idented line on def closeEvent(self, event):
- Added a comment explaing the ' ' in Bible book name auto completion.

2762. By Azaziah on 2017-06-05

Expanded the test_reference_matched_full to include results with dots after numbers, eg. 1. Kings

2761. By Azaziah on 2017-06-04

Improved the regex to check dot after book number and after book name.

2760. By Azaziah on 2017-06-04

Fixed the issue where books with "." can't be used in reference search.

2759. By Azaziah on 2017-06-04

Renamed another wizzard test + comment.

2758. By Azaziah on 2017-06-04

Renamed test: def test_on_import_click_no_import_wizzard_attr(self):
to: def test_on_import_click_no_import_wizard_attr(self):

2757. By Azaziah on 2017-06-04

- Fixed 2 tests

2756. By Azaziah on 2017-06-04

Fixed the new trailing space added by previous pep fix