MongoDB Charm

Code review comment for ~zzehring/charm-mongodb:bugfix/lp1882641-trusty-charm-upgrade-fails-import-pip

  1. Git
  2. lp:~zzehring/charm-mongodb
  3. bugfix/lp1882641-trusty-charm-upgrade-fails-import-pip
  4. Merge into master
Revision history for this message
Andrea Ieri (aieri) wrote :

This looks fine, but I suspect hooks/install is run before hooks/hooks.py, so this could more simply become (in that file):

- declare -a DEPS=('apt' 'netaddr' 'netifaces' 'pip' 'yaml')
+ declare -a DEPS=('apt' 'netaddr' 'netifaces' 'pip' 'yaml' 'python3-pip')

« Back to merge proposal