Code review comment for lp:~zyga/testtools/use-versiontools
Revision history for this message
| Jelmer Vernooij (jelmer) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
I'm not really a testtools reviewer, but involved in the packaging. Some issues I noticed:
This removes the distinction for version phases ("final", "alpha", etc) and causes the version number to be 0.9.14 for all snapshots following release 0.9.14, rather than snapshot-0.9.14. This in particular matters for recipe builds, where we create a source package without the .bzr directory.
It looks like versiontools isn't packaged for Debian or Ubuntu yet. It would be nice if that could happen before testtools starts depending on it, otherwise we can't upload newer versions to Debian/Ubuntu.