Code review comment for lp:~zyga/lava-dashboard/0.1.CONFIGURED-fix

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

> I'm not sure I like this approach. It depends on the administrator to know
> that they need to have CONFIGURED set to something in the local_settings. I
> realize the example has this, but why not just do something like:
> try:
> from local_settings import *
> except ImportError:
> ...do default config here

I agree with the downside. I wanted to have an option of always using local_settings.py (I use it for development to add some extra installed apps and middleware for development). How about we use this approach:

from default_settings import *
try:
    from local_settings import *
except ImportError:
    from development_settings import *

So there would be no CONFIGURED anymore and you could still use local_settings like I do (although you'd need to import development_settings inside your local settings for that).

« Back to merge proposal