Code review comment for lp:~zyga/launchpadlib/fix-1471927

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

In a few other places in that file, the following is done:

        if not isinstance(value, unicode_type):
            value = value.decode('utf-8')

the assumption being that although over the wire things are bytes, we expect them to actually be unicode in most places and try to decode to native string straight away.

Wouldn't above pattern work here as well?

Will check later when reviewing other stuff.

« Back to merge proposal