Code review comment for lp:~zyga/launchpadlib/fix-1471927

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Yep, certainly. I think nothing ever calls the unicode code path there
so in reality you either get str -> str (on python2) or you get bytes
-> str (on python3). The complex test was so that I don't introduce
str -> unicode (on python2) that people may not expect to handle.

On Tue, Jul 7, 2015 at 2:02 AM, Colin Watson <email address hidden> wrote:
> Er, wait, it won't try to decode it because of the first test, so that part of my comment is wrong, sorry. I'd still rather see the simpler version if it works - could you check that?
> --
> https://code.launchpad.net/~zyga/launchpadlib/fix-1471927/+merge/263953
> You are the owner of lp:~zyga/launchpadlib/fix-1471927.

« Back to merge proposal