Code review comment for lp:~zyga/checkbox/selftest

Yeah, it doesn't install any packages. I'll make it do that and
re-submit this branch.

The exit code is a plainbox deficiency. I will really start looking at
this so that 0.2{2,3,4} can improve.
As for tox, yes, but it does things that tox cannot do. Tox is like
pip, this is like dpkg. Self-test is a tox super-set.

Thanks for the feedback.
ZK

On Wed, Mar 25, 2015 at 7:14 PM, Daniel Manrique
<email address hidden> wrote:
> Cool! I tried this inside a container, just ran ./selftest.sh run, and it failed :( because I hadn't installed intltool, which goes to what you mentioned about package installation.
>
> Another thing I noticed is that the exit code was 0 even though some of the tests failed, I wonder if we should have a proper non-success exit code for this.
>
> I'm also thinking about whether it overlaps a bit with tools like tox, which we use in capomastro and hexr.
>
> But in all, this is very nice and allows expressing the rather complicated setup for plainbox tests in a manner that's familiar to a developer who is already working with plainbox. Thanks!
> --
> https://code.launchpad.net/~zyga/checkbox/selftest/+merge/253478
> You are the owner of lp:~zyga/checkbox/selftest.