Code review comment for lp:~zyga/checkbox/selftest

Revision history for this message
Daniel Manrique (roadmr) wrote :

Cool! I tried this inside a container, just ran ./selftest.sh run, and it failed :( because I hadn't installed intltool, which goes to what you mentioned about package installation.

Another thing I noticed is that the exit code was 0 even though some of the tests failed, I wonder if we should have a proper non-success exit code for this.

I'm also thinking about whether it overlaps a bit with tools like tox, which we use in capomastro and hexr.

But in all, this is very nice and allows expressing the rather complicated setup for plainbox tests in a manner that's familiar to a developer who is already working with plainbox. Thanks!

« Back to merge proposal