Checkbox

Merge lp:~zyga/checkbox/fix-1400646 into lp:checkbox

  1. fix-1400646
  2. Merge into trunk
Proposed by Zygmunt Krynicki
Status: Merged
Approved by: Maciej Kisielewski
Approved revision: 3532
Merged at revision: 3532
Proposed branch: lp:~zyga/checkbox/fix-1400646
Merge into: lp:checkbox
Diff against target: 14 lines (+3/-1)
1 file modified
plainbox/plainbox/impl/commands/inv_run.py (+3/-1)
To merge this branch: bzr merge lp:~zyga/checkbox/fix-1400646
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Maciej Kisielewski Approve
Review via email: mp+246877@code.launchpad.net

Description of the change

9f92f79 plainbox:commands:run: limit interaction prompt

To post a comment you must log in.
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

Thanks for solving that one :)

review: Approve
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plainbox/plainbox/impl/commands/inv_run.py'
2--- plainbox/plainbox/impl/commands/inv_run.py 2015-01-07 14:52:42 +0000
3+++ plainbox/plainbox/impl/commands/inv_run.py 2015-01-19 11:27:23 +0000
4@@ -746,7 +746,9 @@
5 if job.plugin in ('user-interact', 'user-interact-verify',
6 'user-verify', 'manual'):
7 ui.notify_about_purpose(job)
8- if self.is_interactive:
9+ if (self.is_interactive and
10+ job.plugin in ('user-interact',
11+ 'user-interact-verify')):
12 cmd = ui.wait_for_interaction_prompt(job)
13 if cmd == 'run' or cmd is None:
14 ui.notify_about_steps(job)

Subscribers

People subscribed via source and target branches