Merge lp:~zyga/checkbox/fix-1302388 into lp:checkbox

[Zygmunt Krynicki]

[Daniel Manrique (roadmr)]

oh cool :) thanks for the detailed explanation, and the fix looks simple enough. Makes sense.

review: Approve

[Zygmunt Krynicki (zyga)]

Note: this probably causes whitelist ordering regression. I'll take a break and confirm this

Sent from my BlackBerry 10 smartphone.
  Original Message
From: Daniel Manrique
Sent: czwartek, 22 maja 2014 19:54
To: <email address hidden>; Daniel Manrique
Reply To: <email address hidden>
Subject: [Merge] lp:~zkrynicki/checkbox/fix-1302388 into lp:checkbox

The proposal to merge lp:~zkrynicki/checkbox/fix-1302388 into lp:checkbox has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~zkrynicki/checkbox/fix-1302388/+merge/220694
--
https://code.launchpad.net/~zkrynicki/checkbox/fix-1302388/+merge/220694
You are the owner of lp:~zkrynicki/checkbox/fix-1302388.

=== modified file 'checkbox-gui/gui-engine/gui-engine.cpp'
--- checkbox-gui/gui-engine/gui-engine.cpp	2014-05-22 15:39:53 +0000
+++ checkbox-gui/gui-engine/gui-engine.cpp	2014-05-22 17:40:42 +0000
@@ -424,10 +424,7 @@
     * so we try to preserve that when we give it to UpdateDesiredJobList()
     * and hopefully it is similar when we get it back from SessionStateRunList()
     */
-    QList<QDBusObjectPath> temp_desired_job_list = \
-            JobTreeNode::FilteredJobs(m_desired_job_list,m_final_run_list);
-
-    QStringList errors = UpdateDesiredJobList(m_session, temp_desired_job_list);
+    QStringList errors = UpdateDesiredJobList(m_session, m_final_run_list);
     if (errors.count() != 0) {
         qDebug("UpdateDesiredJobList generated errors:");
         for (int i=0; i<errors.count(); i++) {