lp:~zyga/checkbox/fix-1302388

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:checkbox at revision 3026

Daniel Manrique (community): Approve on 2014-05-22

Diff: 15 lines (+1/-4)

1 file modified

checkbox-gui/gui-engine/gui-engine.cpp (+1/-4)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1302388: checkbox-gui skips jobs not explicitly present in the whitelist, even if they are selected in the test manager view

Critical

Fix Released

Link a bug report

Related blueprints

3026. By Zygmunt Krynicki on 2014-05-22

checkbox-gui: fix resource jobs (and other jobs) to run

This patch removes the useless (and broken) second-level filtering done
by PrepareJobs().

To quote my comment from launchpad.net:

>>> Ok so here it goes:
>>>
>>> The resource job is not started because it's not present in the
>>> whitelist.
>>>
>>> The gui does some rather confusing filtering. If you think like me, from
>>> plainbox POV, you see a set of jobs and you flag the ones you want to
>>> run (in some order), that gives you the *desired* job list. You pass
>>> that to plainbox's SelectJobs and get the run_list. You follow that and
>>> you're in happy land.
>>>
>>> This is not what happens here:
>>>
>>> First the ideal view is broken by generated jobs. To see all jobs you
>>> need to run some jobs. The GUI does the conservative bit by running
>>> *all* local jobs. This gives it the full job awareness.
>>>
>>> Next comes the job selection view. As you probably recall the list of
>>> jobs displayed in the view where one can select which jobs are to be
>>> executed is not the full list of know jobs. That list is filtered by the
>>> whitelists selected in the whitelist selection screen (I haven't
>>> investigated that part yet). So we can now see our resource jobs because
>>> plainbox knows they are required OR because they were on the whitelist.
>>>
>>> Now this is the critical piece. After making the selection,
>>> PrepareJobs() discards anything that we selected that is not in the
>>> whitelist.

Fixes: https://bugs.launchpad.net/checkbox-gui/+bug/1302388

Signed-off-by: Zygmunt Krynicki <email address hidden>

3025. By Zygmunt Krynicki on 2014-05-22

"automatic merge by tarmac [r=roadmr][bug=][author=zkrynicki]"

3024. By Po-Hsu Lin on 2014-05-22

"automatic merge by tarmac [r=roadmr][bug=1321356][author=cypressyew]"

3023. By Zygmunt Krynicki on 2014-05-22

"automatic merge by tarmac [r=roadmr][bug=][author=zkrynicki]"

3022. By Po-Hsu Lin on 2014-05-22

"automatic merge by tarmac [r=roadmr][bug=1321995][author=cypressyew]"

3021. By Po-Hsu Lin on 2014-05-22

"automatic merge by tarmac [r=zkrynicki][bug=1321357][author=cypressyew]"

3020. By Daniel Manrique on 2014-05-21

"8cd5574 Update tarmac-verify to use lxc containers.
5fa0db5 test-in-lxc: More reliable container destruction.
 [r=roadmr,zkrynicki][bug=][author=roadmr]"

3019. By Sylvain Pineau on 2014-05-21

"automatic merge by tarmac [r=zkrynicki][bug=][author=sylvain-pineau]"

3018. By Sylvain Pineau on 2014-05-21

"automatic merge by tarmac [r=sylvain-pineau][bug=][author=sylvain-pineau]"

3017. By Sylvain Pineau on 2014-05-21

"automatic merge by tarmac [r=zkrynicki][bug=][author=sylvain-pineau]"