Merge lp:~zulcss/neutron/quantum-fix-pep8 into lp:~openstack-ubuntu-testing/neutron/grizzly

Proposed by Chuck Short
Status: Merged
Approved by: Yolanda Robla
Approved revision: 138
Merged at revision: 138
Proposed branch: lp:~zulcss/neutron/quantum-fix-pep8
Merge into: lp:~openstack-ubuntu-testing/neutron/grizzly
Diff against target: 82 lines (+60/-0)
3 files modified
debian/changelog (+1/-0)
debian/patches/fix-pep8-tests.patch (+58/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~zulcss/neutron/quantum-fix-pep8
Reviewer Review Type Date Requested Status
James Page Approve
Yolanda Robla (community) Approve
Review via email: mp+151265@code.launchpad.net

Description of the change

fix pep8 tests.

To post a comment you must log in.
Revision history for this message
Yolanda Robla (yolanda.robla) wrote :

Looks good to me

review: Approve
Revision history for this message
James Page (james-page) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2013-03-01 14:15:07 +0000
+++ debian/changelog 2013-03-01 14:56:33 +0000
@@ -6,6 +6,7 @@
6 * debian/control: Add python-testtools and python-fixtures a build-dep.6 * debian/control: Add python-testtools and python-fixtures a build-dep.
7 * debian/control: Drop python-gflags no longer needed.7 * debian/control: Drop python-gflags no longer needed.
8 * debian/control: Drop python-unittest2 no longer needed.8 * debian/control: Drop python-unittest2 no longer needed.
9 * debian/patches/fix-pep8-tests.patch: Fix pep8 tests.
910
10 [ James Page ]11 [ James Page ]
11 * d/watch: Update uversionmangle to deal with upstream versioning12 * d/watch: Update uversionmangle to deal with upstream versioning
1213
=== added file 'debian/patches/fix-pep8-tests.patch'
--- debian/patches/fix-pep8-tests.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/fix-pep8-tests.patch 2013-03-01 14:56:33 +0000
@@ -0,0 +1,58 @@
1From 0d71ce29f825453761fd52dffb7370fa8fbacb42 Mon Sep 17 00:00:00 2001
2From: Chuck Short <chuck.short@canonical.com>
3Date: Fri, 1 Mar 2013 08:21:31 -0600
4Subject: [PATCH] Pin pep8 to 1.3.3
5
6Apart of making pep8 version standard across all openstack
7projects.
8
9Change-Id: Iefc923123243df161ed72888c1651a622afbda04
10Signed-off-by: Chuck Short <chuck.short@canonical.com>
11---
12 quantum/scheduler/dhcp_agent_scheduler.py | 2 +-
13 quantum/scheduler/l3_agent_scheduler.py | 2 +-
14 tools/test-requires | 2 +-
15 3 files changed, 3 insertions(+), 3 deletions(-)
16
17diff --git a/quantum/scheduler/dhcp_agent_scheduler.py b/quantum/scheduler/dhcp_agent_scheduler.py
18index 6292988..e3810ce 100644
19--- a/quantum/scheduler/dhcp_agent_scheduler.py
20+++ b/quantum/scheduler/dhcp_agent_scheduler.py
21@@ -81,7 +81,7 @@ class ChanceScheduler(object):
22 query = query.filter(agents_db.Agent.agent_type ==
23 constants.AGENT_TYPE_DHCP,
24 agents_db.Agent.host == host,
25- agents_db.Agent.admin_state_up == True)
26+ agents_db.Agent.admin_state_up is True)
27 try:
28 dhcp_agent = query.one()
29 except (exc.MultipleResultsFound, exc.NoResultFound):
30diff --git a/quantum/scheduler/l3_agent_scheduler.py b/quantum/scheduler/l3_agent_scheduler.py
31index 0d3b1ef..6e99346 100644
32--- a/quantum/scheduler/l3_agent_scheduler.py
33+++ b/quantum/scheduler/l3_agent_scheduler.py
34@@ -48,7 +48,7 @@ class ChanceScheduler(object):
35 query = query.filter(agents_db.Agent.agent_type ==
36 constants.AGENT_TYPE_L3,
37 agents_db.Agent.host == host,
38- agents_db.Agent.admin_state_up == True)
39+ agents_db.Agent.admin_state_up is True)
40 try:
41 l3_agent = query.one()
42 except (exc.MultipleResultsFound, exc.NoResultFound):
43diff --git a/tools/test-requires b/tools/test-requires
44index d86688e..8e93e94 100644
45--- a/tools/test-requires
46+++ b/tools/test-requires
47@@ -9,7 +9,7 @@ nose
48 nosehtmloutput
49 nosexcover
50 openstack.nose_plugin
51-pep8
52+pep8==1.3.3
53 sphinx>=1.1.2
54 testtools>=0.9.27
55 webtest==1.3.3
56--
571.8.1.2
58
059
=== modified file 'debian/patches/series'
--- debian/patches/series 2013-02-27 15:02:09 +0000
+++ debian/patches/series 2013-03-01 14:56:33 +0000
@@ -1,2 +1,3 @@
1fix-quantum-configuration.patch1fix-quantum-configuration.patch
2fix-ubuntu-tests.patch2fix-ubuntu-tests.patch
3fix-pep8-tests.patch

Subscribers

People subscribed via source and target branches