Merge lp:~zulcss/neutron/quantum-fix-pep8 into lp:~openstack-ubuntu-testing/neutron/grizzly

Proposed by Chuck Short
Status: Merged
Approved by: Yolanda Robla
Approved revision: 138
Merged at revision: 138
Proposed branch: lp:~zulcss/neutron/quantum-fix-pep8
Merge into: lp:~openstack-ubuntu-testing/neutron/grizzly
Diff against target: 82 lines (+60/-0)
3 files modified
debian/changelog (+1/-0)
debian/patches/fix-pep8-tests.patch (+58/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~zulcss/neutron/quantum-fix-pep8
Reviewer Review Type Date Requested Status
James Page Approve
Yolanda Robla (community) Approve
Review via email: mp+151265@code.launchpad.net

Description of the change

fix pep8 tests.

To post a comment you must log in.
Revision history for this message
Yolanda Robla (yolanda.robla) wrote :

Looks good to me

review: Approve
Revision history for this message
James Page (james-page) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-03-01 14:15:07 +0000
3+++ debian/changelog 2013-03-01 14:56:33 +0000
4@@ -6,6 +6,7 @@
5 * debian/control: Add python-testtools and python-fixtures a build-dep.
6 * debian/control: Drop python-gflags no longer needed.
7 * debian/control: Drop python-unittest2 no longer needed.
8+ * debian/patches/fix-pep8-tests.patch: Fix pep8 tests.
9
10 [ James Page ]
11 * d/watch: Update uversionmangle to deal with upstream versioning
12
13=== added file 'debian/patches/fix-pep8-tests.patch'
14--- debian/patches/fix-pep8-tests.patch 1970-01-01 00:00:00 +0000
15+++ debian/patches/fix-pep8-tests.patch 2013-03-01 14:56:33 +0000
16@@ -0,0 +1,58 @@
17+From 0d71ce29f825453761fd52dffb7370fa8fbacb42 Mon Sep 17 00:00:00 2001
18+From: Chuck Short <chuck.short@canonical.com>
19+Date: Fri, 1 Mar 2013 08:21:31 -0600
20+Subject: [PATCH] Pin pep8 to 1.3.3
21+
22+Apart of making pep8 version standard across all openstack
23+projects.
24+
25+Change-Id: Iefc923123243df161ed72888c1651a622afbda04
26+Signed-off-by: Chuck Short <chuck.short@canonical.com>
27+---
28+ quantum/scheduler/dhcp_agent_scheduler.py | 2 +-
29+ quantum/scheduler/l3_agent_scheduler.py | 2 +-
30+ tools/test-requires | 2 +-
31+ 3 files changed, 3 insertions(+), 3 deletions(-)
32+
33+diff --git a/quantum/scheduler/dhcp_agent_scheduler.py b/quantum/scheduler/dhcp_agent_scheduler.py
34+index 6292988..e3810ce 100644
35+--- a/quantum/scheduler/dhcp_agent_scheduler.py
36++++ b/quantum/scheduler/dhcp_agent_scheduler.py
37+@@ -81,7 +81,7 @@ class ChanceScheduler(object):
38+ query = query.filter(agents_db.Agent.agent_type ==
39+ constants.AGENT_TYPE_DHCP,
40+ agents_db.Agent.host == host,
41+- agents_db.Agent.admin_state_up == True)
42++ agents_db.Agent.admin_state_up is True)
43+ try:
44+ dhcp_agent = query.one()
45+ except (exc.MultipleResultsFound, exc.NoResultFound):
46+diff --git a/quantum/scheduler/l3_agent_scheduler.py b/quantum/scheduler/l3_agent_scheduler.py
47+index 0d3b1ef..6e99346 100644
48+--- a/quantum/scheduler/l3_agent_scheduler.py
49++++ b/quantum/scheduler/l3_agent_scheduler.py
50+@@ -48,7 +48,7 @@ class ChanceScheduler(object):
51+ query = query.filter(agents_db.Agent.agent_type ==
52+ constants.AGENT_TYPE_L3,
53+ agents_db.Agent.host == host,
54+- agents_db.Agent.admin_state_up == True)
55++ agents_db.Agent.admin_state_up is True)
56+ try:
57+ l3_agent = query.one()
58+ except (exc.MultipleResultsFound, exc.NoResultFound):
59+diff --git a/tools/test-requires b/tools/test-requires
60+index d86688e..8e93e94 100644
61+--- a/tools/test-requires
62++++ b/tools/test-requires
63+@@ -9,7 +9,7 @@ nose
64+ nosehtmloutput
65+ nosexcover
66+ openstack.nose_plugin
67+-pep8
68++pep8==1.3.3
69+ sphinx>=1.1.2
70+ testtools>=0.9.27
71+ webtest==1.3.3
72+--
73+1.8.1.2
74+
75
76=== modified file 'debian/patches/series'
77--- debian/patches/series 2013-02-27 15:02:09 +0000
78+++ debian/patches/series 2013-03-01 14:56:33 +0000
79@@ -1,2 +1,3 @@
80 fix-quantum-configuration.patch
81 fix-ubuntu-tests.patch
82+fix-pep8-tests.patch

Subscribers

People subscribed via source and target branches