Code review comment for lp:~zulcss/openstack-charm-testing/lxd-qa

Revision history for this message
Ryan Beisner (1chb1n) wrote :

I'd like to stick with the original o-c-t method of keeping YMMV/in-flight stuff in bundles/dev.

Here's what I'd like to see:

bundles/dev/lxd/*
In-flight, development bundle things. Things may move, come and go and disappear here. The dev dir can be the wild west. Nothing in the dev dir is automated. Some things there may be temporary WIP duplicates of bundles/lxd bits, and that is ok.

bundles/lxd/*
Should contain only maintained reference bundles. Other people will ask, we will point them here. We will also test from here. No need for a QA dir, as that is implied for anything in this dir.

bundles/lxd/source/next.yaml
bundles/lxd/source/stable.yaml
Deploy from source bundles. These are/may/will be automated. These should be THE reference lxd bundles for deploy-from-source, next and stable.

bundles/lxd/next.yaml
bundles/lxd/stable.yaml
This is automated. Keep these here as THE reference lxd bundles for the stable and next charms sets.

All bundles in o-c-t should indicate stable or next in the bundle file name. Most of your work will likely be next, and that's ok. If I need to create a stable bundle based on that, I can do that later without a file name conflict. So, for example, there wouldn't be a lxd.yaml bundle file anywhere in the mix.

Your bot who relies on programmatically predictable and stable file and folder names thanks you a ton. :-)

review: Needs Fixing

« Back to merge proposal