Code review comment for lp:~zulcss/nova/testr-fallout

Revision history for this message
James Page (james-page) wrote :

Hi Chuck

Changes look OK - however still get a build failure:

./run_tests.sh -N
Running ` testr run --parallel `
running=${PYTHON:-python} -m subunit.run discover -t ./ ./nova/tests --list
running=${PYTHON:-python} -m subunit.run discover -t ./ ./nova/tests --load-list /tmp/tmp1wQlXL
running=${PYTHON:-python} -m subunit.run discover -t ./ ./nova/tests --load-list /tmp/tmpVcdBoi
running=${PYTHON:-python} -m subunit.run discover -t ./ ./nova/tests --load-list /tmp/tmpFcbK9Z
running=${PYTHON:-python} -m subunit.run discover -t ./ ./nova/tests --load-list /tmp/tmpqLO4BC
running=${PYTHON:-python} -m subunit.run discover -t ./ ./nova/tests --load-list /tmp/tmpn1wazz
running=${PYTHON:-python} -m subunit.run discover -t ./ ./nova/tests --load-list /tmp/tmp6WQdXH
running=${PYTHON:-python} -m subunit.run discover -t ./ ./nova/tests --load-list /tmp/tmpAO6X34
running=${PYTHON:-python} -m subunit.run discover -t ./ ./nova/tests --load-list /tmp/tmp0fzn89
2013-01-07 10:48:55 32351 WARNING nova.virt.libvirt.firewall [-] Libvirt module could not be loaded. NWFilterFirewall will not work correctly.
2013-01-07 10:48:55 32358 WARNING nova.virt.libvirt.firewall [-] Libvirt module could not be loaded. NWFilterFirewall will not work correctly.
2013-01-07 10:48:55 32356 WARNING nova.virt.libvirt.firewall [-] Libvirt module could not be loaded. NWFilterFirewall will not work correctly.
2013-01-07 10:48:56 32364 WARNING nova.virt.libvirt.firewall [-] Libvirt module could not be loaded. NWFilterFirewall will not work correctly.
2013-01-07 10:48:56 32349 WARNING nova.virt.libvirt.firewall [-] Libvirt module could not be loaded. NWFilterFirewall will not work correctly.
2013-01-07 10:48:56 32359 WARNING nova.virt.libvirt.firewall [-] Libvirt module could not be loaded. NWFilterFirewall will not work correctly.
2013-01-07 10:48:56 32354 WARNING nova.virt.libvirt.firewall [-] Libvirt module could not be loaded. NWFilterFirewall will not work correctly.
2013-01-07 10:48:56 32362 WARNING nova.virt.libvirt.firewall [-] Libvirt module could not be loaded. NWFilterFirewall will not work correctly.
Ran 4316 tests in 269.189s
PASSED (id=0, skips=20)
Running PEP8 and HACKING compliance check...
fatal: Not a git repository (or any of the parent directories): .git
Traceback (most recent call last):
  File "tools/hacking.py", line 468, in <module>
    once_error = once_git_check_commit_title()
  File "tools/hacking.py", line 441, in once_git_check_commit_title
    raise Exception("git log failed with code %s" % subp.returncode)
Exception: git log failed with code 128
make[1]: *** [override_dh_auto_test] Error 1
make[1]: Leaving directory `/«PKGBUILDDIR»'
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2

review: Needs Fixing

« Back to merge proposal