Code review comment for lp:~zulcss/nova/nova-lxc

Revision history for this message
Soren Hansen (soren) wrote :

> + device = _link_device(image, nbd)
> + out, err = utils.execute('sudo', 'mount', device, container_dir)
> + if err:
> + raise exception.Error(_('Failed to mount filesystem: %s')
> + % err)
> + _unlink_device(device, nbd)

If mount gives a non-zero exit code, it'll raise an exception. You
should catch and handle that, too.

I think that's all I have to add that hasn't already been pointed out.

That said, I still haven't actually tested it, but we're at a point now
where, if you address these couple of things, I'm actually willing to
believe it'll behave :), and if not, help fix it up.

« Back to merge proposal