Code review comment for lp:~zulcss/nova/nova-lxc

Everything looks good except for your setup and destroy container:

1) nbd should be based on FLAGS.use_cow_images instead of arbitrarily set to "False" (which is a string btw so it will evaluate to True)

2) destroy container should use _unlink_device so it can destroy using nbd or loopback. Looks like there is some trickiness with how to keep track of the device that the image is using, but you need to support an nbd version and a loopback version.

NBD may be a performance issue, so an alternative solution is to force use_cow_images to be False if we are using lxc, and change the line in setup_container to nbd=False (without the quotes)