Code review comment for lp:~zulcss/nova/nova-lxc

Revision history for this message
termie (termie) wrote :

- you've got extra whitespaces at lines: 33, 38
- 41: you should be using self.flags(libvirt_type='lxc') to override flags so that they are automatically reset at the end of the test
- your test seems to rely on libvirt being available which is not always the case, perhaps you should skip the test if libvirt is not available? otherwise it doesn't seem like it is testing anything.
- at line 51 you should move line 52 up to that line and indent line 53 to to match it
- 71: please add punctuation to your docstring
- 81: missing a space on your indent
- in the new xml template you appear to have removed a feature related to multiple nics, what was the reasoning behind that?

other than that stuff, looks pretty cool :)

review: Needs Fixing

« Back to merge proposal