Code review comment for lp:~zulcss/nova/nova-lxc

Revision history for this message
Chuck Short (zulcss) wrote :

> Hi Chuck!
>
> 149 + utils.execute('mkdir -p %s' % container_dir)
>
> Does the above need a sudo?
>
> Also, I note that there are no test cases included for this new functionality.
> Could we add some?
>
> Cheers!
> jay

Hi Jay,

It doesnt need sudo because its running as the nova user. Also the tests were added in revision 753.

chuck

« Back to merge proposal