Merge lp:~zulcss/keystone/keystoneclient-refresh into lp:~ubuntu-server-dev/keystone/icehouse

Proposed by Chuck Short
Status: Merged
Approved by: Chuck Short
Approved revision: 243
Merged at revision: 243
Proposed branch: lp:~zulcss/keystone/keystoneclient-refresh
Merge into: lp:~ubuntu-server-dev/keystone/icehouse
Diff against target: 151 lines (+8/-126)
1 file modified
debian/patches/fix-ubuntu-tests.patch (+8/-126)
To merge this branch: bzr merge lp:~zulcss/keystone/keystoneclient-refresh
Reviewer Review Type Date Requested Status
Andres Rodriguez (community) Approve
Review via email: mp+199139@code.launchpad.net

Description of the change

Refreshed patch

To post a comment you must log in.
Revision history for this message
Andres Rodriguez (andreserl) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/patches/fix-ubuntu-tests.patch'
--- debian/patches/fix-ubuntu-tests.patch 2013-12-06 16:57:38 +0000
+++ debian/patches/fix-ubuntu-tests.patch 2013-12-16 15:13:19 +0000
@@ -2,7 +2,7 @@
2Author: Chuck Short <zulcss@ubuntu.com>2Author: Chuck Short <zulcss@ubuntu.com>
3Forwarded: not-needed3Forwarded: not-needed
4diff --git a/keystone/tests/test_keystoneclient.py b/keystone/tests/test_keystoneclient.py4diff --git a/keystone/tests/test_keystoneclient.py b/keystone/tests/test_keystoneclient.py
5index fb8027e..3e532f1 1006445index c34c5bf..57092cb 100644
6--- a/keystone/tests/test_keystoneclient.py6--- a/keystone/tests/test_keystoneclient.py
7+++ b/keystone/tests/test_keystoneclient.py7+++ b/keystone/tests/test_keystoneclient.py
8@@ -55,13 +55,13 @@ class CompatTestCase(tests.NoModule, tests.TestCase):8@@ -55,13 +55,13 @@ class CompatTestCase(tests.NoModule, tests.TestCase):
@@ -16,132 +16,14 @@
16- revdir = tests.checkout_vendor(*checkout_info)16- revdir = tests.checkout_vendor(*checkout_info)
17- self.add_path(revdir)17- self.add_path(revdir)
18- self.clear_module('keystoneclient')18- self.clear_module('keystoneclient')
19+# checkout_info = self.get_checkout()19+ #checkout_info = self.get_checkout()
20+# if isinstance(checkout_info, str):20+ #if isinstance(checkout_info, str):
21+# revdir = checkout_info21+ # revdir = checkout_info
22+# else:22+ #else:
23+# revdir = tests.checkout_vendor(*checkout_info)23+ # revdir = tests.checkout_vendor(*checkout_info)
24+# self.add_path(revdir)24+ #self.add_path(revdir)
25+# self.clear_module('keystoneclient')25+ #self.clear_module('keystoneclient')
26 26
27 def _public_url(self):27 def _public_url(self):
28 public_port = self.public_server.socket_info['socket'][1]28 public_port = self.public_server.socket_info['socket'][1]
29@@ -1085,115 +1085,3 @@ class KcOptTestCase(KcMasterTestCase):
30
31 def get_checkout(self):
32 return self.path
33-
34-
35-class KcEssex3TestCase(CompatTestCase, KeystoneClientTests):
36- def get_checkout(self):
37- return KEYSTONECLIENT_REPO, 'essex-3'
38-
39- def test_tenant_add_and_remove_user(self):
40- client = self.get_client(admin=True)
41- client.roles.add_user_to_tenant(tenant_id=self.tenant_bar['id'],
42- user_id=self.user_two['id'],
43- role_id=self.role_member['id'])
44- role_refs = client.roles.get_user_role_refs(
45- user_id=self.user_two['id'])
46- self.assertTrue(self.tenant_baz['id'] in
47- [x.tenantId for x in role_refs])
48-
49- # get the "role_refs" so we get the proper id, this is how the clients
50- # do it
51- roleref_refs = client.roles.get_user_role_refs(
52- user_id=self.user_two['id'])
53- for roleref_ref in roleref_refs:
54- if (roleref_ref.roleId == self.role_member['id']
55- and roleref_ref.tenantId == self.tenant_baz['id']):
56- # use python's scope fall through to leave roleref_ref set
57- break
58-
59- client.roles.remove_user_from_tenant(tenant_id=self.tenant_bar['id'],
60- user_id=self.user_two['id'],
61- role_id=roleref_ref.id)
62-
63- role_refs = client.roles.get_user_role_refs(
64- user_id=self.user_two['id'])
65- self.assertTrue(self.tenant_baz['id'] not in
66- [x.tenantId for x in role_refs])
67-
68- def test_roles_get_by_user(self):
69- client = self.get_client(admin=True)
70- roles = client.roles.get_user_role_refs(user_id='foo')
71- self.assertTrue(len(roles) > 0)
72-
73- def test_role_list_404(self):
74- self.skipTest('N/A')
75-
76- def test_authenticate_and_delete_token(self):
77- self.skipTest('N/A')
78-
79- def test_user_create_update_delete(self):
80- from keystoneclient import exceptions as client_exceptions
81-
82- test_username = 'new_user'
83- client = self.get_client(admin=True)
84- user = client.users.create(name=test_username,
85- password='password',
86- email='user1@test.com')
87- self.assertEqual(user.name, test_username)
88-
89- user = client.users.get(user=user.id)
90- self.assertEqual(user.name, test_username)
91-
92- user = client.users.update_email(user=user, email='user2@test.com')
93- self.assertEqual(user.email, 'user2@test.com')
94-
95- # NOTE(termie): update_enabled doesn't return anything, probably a bug
96- client.users.update_enabled(user=user, enabled=False)
97- user = client.users.get(user.id)
98- self.assertFalse(user.enabled)
99-
100- self.assertRaises(client_exceptions.Unauthorized,
101- self._client,
102- username=test_username,
103- password='password')
104- client.users.update_enabled(user, True)
105-
106- user = client.users.update_password(user=user, password='password2')
107-
108- self._client(username=test_username,
109- password='password2')
110-
111- user = client.users.update_tenant(user=user, tenant='bar')
112- # TODO(ja): once keystonelight supports default tenant
113- # when you login without specifying tenant, the
114- # token should be scoped to tenant 'bar'
115-
116- client.users.delete(user.id)
117- self.assertRaises(client_exceptions.NotFound, client.users.get,
118- user.id)
119-
120- def test_user_update_404(self):
121- self.skipTest('N/A')
122-
123- def test_endpoint_create_404(self):
124- self.skipTest('N/A')
125-
126- def test_endpoint_delete_404(self):
127- self.skipTest('N/A')
128-
129- def test_policy_crud(self):
130- self.skipTest('N/A due to lack of endpoint CRUD')
131-
132- def test_disable_tenant_invalidates_token(self):
133- self.skipTest('N/A')
134-
135- def test_delete_tenant_invalidates_token(self):
136- self.skipTest('N/A')
137-
138-
139-class Kc11TestCase(CompatTestCase, KeystoneClientTests):
140- def get_checkout(self):
141- return KEYSTONECLIENT_REPO, '0.1.1'
142-
143- def test_policy_crud(self):
144- self.skipTest('N/A')
145--
1461.8.5.1
14729

Subscribers

People subscribed via source and target branches