Merge lp:~zulcss/keystone/keystoneclient-refresh into lp:~ubuntu-server-dev/keystone/icehouse

Proposed by Chuck Short
Status: Merged
Approved by: Chuck Short
Approved revision: 243
Merged at revision: 243
Proposed branch: lp:~zulcss/keystone/keystoneclient-refresh
Merge into: lp:~ubuntu-server-dev/keystone/icehouse
Diff against target: 151 lines (+8/-126)
1 file modified
debian/patches/fix-ubuntu-tests.patch (+8/-126)
To merge this branch: bzr merge lp:~zulcss/keystone/keystoneclient-refresh
Reviewer Review Type Date Requested Status
Andres Rodriguez (community) Approve
Review via email: mp+199139@code.launchpad.net

Description of the change

Refreshed patch

To post a comment you must log in.
Revision history for this message
Andres Rodriguez (andreserl) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/patches/fix-ubuntu-tests.patch'
2--- debian/patches/fix-ubuntu-tests.patch 2013-12-06 16:57:38 +0000
3+++ debian/patches/fix-ubuntu-tests.patch 2013-12-16 15:13:19 +0000
4@@ -2,7 +2,7 @@
5 Author: Chuck Short <zulcss@ubuntu.com>
6 Forwarded: not-needed
7 diff --git a/keystone/tests/test_keystoneclient.py b/keystone/tests/test_keystoneclient.py
8-index fb8027e..3e532f1 100644
9+index c34c5bf..57092cb 100644
10 --- a/keystone/tests/test_keystoneclient.py
11 +++ b/keystone/tests/test_keystoneclient.py
12 @@ -55,13 +55,13 @@ class CompatTestCase(tests.NoModule, tests.TestCase):
13@@ -16,132 +16,14 @@
14 - revdir = tests.checkout_vendor(*checkout_info)
15 - self.add_path(revdir)
16 - self.clear_module('keystoneclient')
17-+# checkout_info = self.get_checkout()
18-+# if isinstance(checkout_info, str):
19-+# revdir = checkout_info
20-+# else:
21-+# revdir = tests.checkout_vendor(*checkout_info)
22-+# self.add_path(revdir)
23-+# self.clear_module('keystoneclient')
24++ #checkout_info = self.get_checkout()
25++ #if isinstance(checkout_info, str):
26++ # revdir = checkout_info
27++ #else:
28++ # revdir = tests.checkout_vendor(*checkout_info)
29++ #self.add_path(revdir)
30++ #self.clear_module('keystoneclient')
31
32 def _public_url(self):
33 public_port = self.public_server.socket_info['socket'][1]
34-@@ -1085,115 +1085,3 @@ class KcOptTestCase(KcMasterTestCase):
35-
36- def get_checkout(self):
37- return self.path
38--
39--
40--class KcEssex3TestCase(CompatTestCase, KeystoneClientTests):
41-- def get_checkout(self):
42-- return KEYSTONECLIENT_REPO, 'essex-3'
43--
44-- def test_tenant_add_and_remove_user(self):
45-- client = self.get_client(admin=True)
46-- client.roles.add_user_to_tenant(tenant_id=self.tenant_bar['id'],
47-- user_id=self.user_two['id'],
48-- role_id=self.role_member['id'])
49-- role_refs = client.roles.get_user_role_refs(
50-- user_id=self.user_two['id'])
51-- self.assertTrue(self.tenant_baz['id'] in
52-- [x.tenantId for x in role_refs])
53--
54-- # get the "role_refs" so we get the proper id, this is how the clients
55-- # do it
56-- roleref_refs = client.roles.get_user_role_refs(
57-- user_id=self.user_two['id'])
58-- for roleref_ref in roleref_refs:
59-- if (roleref_ref.roleId == self.role_member['id']
60-- and roleref_ref.tenantId == self.tenant_baz['id']):
61-- # use python's scope fall through to leave roleref_ref set
62-- break
63--
64-- client.roles.remove_user_from_tenant(tenant_id=self.tenant_bar['id'],
65-- user_id=self.user_two['id'],
66-- role_id=roleref_ref.id)
67--
68-- role_refs = client.roles.get_user_role_refs(
69-- user_id=self.user_two['id'])
70-- self.assertTrue(self.tenant_baz['id'] not in
71-- [x.tenantId for x in role_refs])
72--
73-- def test_roles_get_by_user(self):
74-- client = self.get_client(admin=True)
75-- roles = client.roles.get_user_role_refs(user_id='foo')
76-- self.assertTrue(len(roles) > 0)
77--
78-- def test_role_list_404(self):
79-- self.skipTest('N/A')
80--
81-- def test_authenticate_and_delete_token(self):
82-- self.skipTest('N/A')
83--
84-- def test_user_create_update_delete(self):
85-- from keystoneclient import exceptions as client_exceptions
86--
87-- test_username = 'new_user'
88-- client = self.get_client(admin=True)
89-- user = client.users.create(name=test_username,
90-- password='password',
91-- email='user1@test.com')
92-- self.assertEqual(user.name, test_username)
93--
94-- user = client.users.get(user=user.id)
95-- self.assertEqual(user.name, test_username)
96--
97-- user = client.users.update_email(user=user, email='user2@test.com')
98-- self.assertEqual(user.email, 'user2@test.com')
99--
100-- # NOTE(termie): update_enabled doesn't return anything, probably a bug
101-- client.users.update_enabled(user=user, enabled=False)
102-- user = client.users.get(user.id)
103-- self.assertFalse(user.enabled)
104--
105-- self.assertRaises(client_exceptions.Unauthorized,
106-- self._client,
107-- username=test_username,
108-- password='password')
109-- client.users.update_enabled(user, True)
110--
111-- user = client.users.update_password(user=user, password='password2')
112--
113-- self._client(username=test_username,
114-- password='password2')
115--
116-- user = client.users.update_tenant(user=user, tenant='bar')
117-- # TODO(ja): once keystonelight supports default tenant
118-- # when you login without specifying tenant, the
119-- # token should be scoped to tenant 'bar'
120--
121-- client.users.delete(user.id)
122-- self.assertRaises(client_exceptions.NotFound, client.users.get,
123-- user.id)
124--
125-- def test_user_update_404(self):
126-- self.skipTest('N/A')
127--
128-- def test_endpoint_create_404(self):
129-- self.skipTest('N/A')
130--
131-- def test_endpoint_delete_404(self):
132-- self.skipTest('N/A')
133--
134-- def test_policy_crud(self):
135-- self.skipTest('N/A due to lack of endpoint CRUD')
136--
137-- def test_disable_tenant_invalidates_token(self):
138-- self.skipTest('N/A')
139--
140-- def test_delete_tenant_invalidates_token(self):
141-- self.skipTest('N/A')
142--
143--
144--class Kc11TestCase(CompatTestCase, KeystoneClientTests):
145-- def get_checkout(self):
146-- return KEYSTONECLIENT_REPO, '0.1.1'
147--
148-- def test_policy_crud(self):
149-- self.skipTest('N/A')
150---
151-1.8.5.1
152

Subscribers

People subscribed via source and target branches