Merge lp:~zsombi/ubuntu-ui-toolkit/vibrateAgain into lp:ubuntu-ui-toolkit/staging

Proposed by Zsombor Egri
Status: Merged
Approved by: Timo Jyrinki
Approved revision: 2062
Merged at revision: 2062
Proposed branch: lp:~zsombi/ubuntu-ui-toolkit/vibrateAgain
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 34 lines (+1/-15)
1 file modified
src/Ubuntu/Components/1.1/Haptics.qml (+1/-15)
To merge this branch: bzr merge lp:~zsombi/ubuntu-ui-toolkit/vibrateAgain
Reviewer Review Type Date Requested Status
ubuntu-sdk-build-bot continuous-integration Approve
Tim Peeters Approve
Review via email: mp+302990@code.launchpad.net

Commit message

No need to check the setting anymore when vibrate.

To post a comment you must log in.
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Tim Peeters (tpeeters) wrote :

This should be handled by usensord now. Depending on the setting in system settings that will vibrate or not, and we can always have it enabled.

review: Approve
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Retrying top-approve, phones fixed.

Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/Ubuntu/Components/1.1/Haptics.qml'
--- src/Ubuntu/Components/1.1/Haptics.qml 2015-08-19 08:44:45 +0000
+++ src/Ubuntu/Components/1.1/Haptics.qml 2016-08-16 08:33:35 +0000
@@ -19,13 +19,10 @@
19import Ubuntu.Components 1.119import Ubuntu.Components 1.1
2020
21Object {21Object {
22 readonly property alias enabled: vibra.otherVibrate22 readonly property bool enabled: true
23 property alias effect: effect23 property alias effect: effect
2424
25 function play(customEffect) {25 function play(customEffect) {
26 if (!vibra.otherVibrate) {
27 return;
28 }
29 if (effectData.data) {26 if (effectData.data) {
30 // we have a custom effect playing, stop it27 // we have a custom effect playing, stop it
31 effect.stop();28 effect.stop();
@@ -76,15 +73,4 @@
76 }73 }
77 }74 }
78 }75 }
79
80 // watch system settings for otherVibrate
81 ServiceProperties {
82 objectName: "system_effect_settings"
83 id: vibra
84 service: "org.freedesktop.Accounts"
85 serviceInterface: "org.freedesktop.Accounts"
86 path: "/org/freedesktop/Accounts"
87 adaptorInterface: "com.ubuntu.touch.AccountsService.Sound"
88 property bool otherVibrate: true
89 }
90}76}

Subscribers

People subscribed via source and target branches