Merge lp:~zsombi/ubuntu-ui-toolkit/vibrateAgain into lp:ubuntu-ui-toolkit/staging

Proposed by Zsombor Egri
Status: Merged
Approved by: Timo Jyrinki
Approved revision: 2062
Merged at revision: 2062
Proposed branch: lp:~zsombi/ubuntu-ui-toolkit/vibrateAgain
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 34 lines (+1/-15)
1 file modified
src/Ubuntu/Components/1.1/Haptics.qml (+1/-15)
To merge this branch: bzr merge lp:~zsombi/ubuntu-ui-toolkit/vibrateAgain
Reviewer Review Type Date Requested Status
ubuntu-sdk-build-bot continuous-integration Approve
Tim Peeters Approve
Review via email: mp+302990@code.launchpad.net

Commit message

No need to check the setting anymore when vibrate.

To post a comment you must log in.
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Tim Peeters (tpeeters) wrote :

This should be handled by usensord now. Depending on the setting in system settings that will vibrate or not, and we can always have it enabled.

review: Approve
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Retrying top-approve, phones fixed.

Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Ubuntu/Components/1.1/Haptics.qml'
2--- src/Ubuntu/Components/1.1/Haptics.qml 2015-08-19 08:44:45 +0000
3+++ src/Ubuntu/Components/1.1/Haptics.qml 2016-08-16 08:33:35 +0000
4@@ -19,13 +19,10 @@
5 import Ubuntu.Components 1.1
6
7 Object {
8- readonly property alias enabled: vibra.otherVibrate
9+ readonly property bool enabled: true
10 property alias effect: effect
11
12 function play(customEffect) {
13- if (!vibra.otherVibrate) {
14- return;
15- }
16 if (effectData.data) {
17 // we have a custom effect playing, stop it
18 effect.stop();
19@@ -76,15 +73,4 @@
20 }
21 }
22 }
23-
24- // watch system settings for otherVibrate
25- ServiceProperties {
26- objectName: "system_effect_settings"
27- id: vibra
28- service: "org.freedesktop.Accounts"
29- serviceInterface: "org.freedesktop.Accounts"
30- path: "/org/freedesktop/Accounts"
31- adaptorInterface: "com.ubuntu.touch.AccountsService.Sound"
32- property bool otherVibrate: true
33- }
34 }

Subscribers

People subscribed via source and target branches