Merge lp:~zsombi/ubuntu-ui-toolkit/thindivider-margins into lp:ubuntu-ui-toolkit/staging

Proposed by Zsombor Egri
Status: Merged
Approved by: Zsombor Egri
Approved revision: 1306
Merged at revision: 1308
Proposed branch: lp:~zsombi/ubuntu-ui-toolkit/thindivider-margins
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 86 lines (+51/-9)
3 files modified
modules/Ubuntu/Components/ListItems/Empty.qml (+1/-5)
modules/Ubuntu/Components/ListItems/ThinDivider.qml (+4/-4)
tests/resources/listitems/Dividers.qml (+46/-0)
To merge this branch: bzr merge lp:~zsombi/ubuntu-ui-toolkit/thindivider-margins
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Tim Peeters Approve
Review via email: mp+239320@code.launchpad.net

Commit message

ThinDivider margins rolled back to edge-to-edge. Divider colors adjusted with design.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Tim Peeters (tpeeters) wrote :

thank you

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'modules/Ubuntu/Components/ListItems/Empty.qml'
--- modules/Ubuntu/Components/ListItems/Empty.qml 2014-10-02 13:03:22 +0000
+++ modules/Ubuntu/Components/ListItems/Empty.qml 2014-10-24 15:04:57 +0000
@@ -307,11 +307,7 @@
307307
308 ThinDivider {308 ThinDivider {
309 id: bottomDividerLine309 id: bottomDividerLine
310 anchors {310 anchors.bottom: parent.bottom
311 bottom: parent.bottom
312 leftMargin: units.gu(2)
313 rightMargin: units.gu(2)
314 }
315 visible: showDivider && !priv.removed311 visible: showDivider && !priv.removed
316 }312 }
317313
318314
=== modified file 'modules/Ubuntu/Components/ListItems/ThinDivider.qml'
--- modules/Ubuntu/Components/ListItems/ThinDivider.qml 2014-09-09 04:59:23 +0000
+++ modules/Ubuntu/Components/ListItems/ThinDivider.qml 2014-10-24 15:04:57 +0000
@@ -57,9 +57,9 @@
57 property bool __lightBackground: ColorUtils.luminance(Theme.palette.normal.background) > 0.8557 property bool __lightBackground: ColorUtils.luminance(Theme.palette.normal.background) > 0.85
58 // use a gradient of 4 steps instead of instantiating two Rectangles for performance reasons58 // use a gradient of 4 steps instead of instantiating two Rectangles for performance reasons
59 gradient: Gradient {59 gradient: Gradient {
60 GradientStop { position: 0.0; color: __lightBackground ? "#26000000" : "#26FFFFFF" }60 GradientStop { position: 0.0; color: __lightBackground ? Qt.rgba(0, 0, 0, 0.1) : Qt.rgba(0, 0, 0, 0.4) }
61 GradientStop { position: 0.49; color: __lightBackground ? "#26000000" : "#26FFFFFF" }61 GradientStop { position: 0.49; color: __lightBackground ? Qt.rgba(0, 0, 0, 0.1) : Qt.rgba(0, 0, 0, 0.4) }
62 GradientStop { position: 0.5; color: __lightBackground ? "#14FFFFFF" : "#14000000" }62 GradientStop { position: 0.5; color: __lightBackground ? Qt.rgba(1, 1, 1, 0.4) : Qt.rgba(1, 1, 1, 0.1) }
63 GradientStop { position: 1.0; color: __lightBackground ? "#14FFFFFF" : "#14000000" }63 GradientStop { position: 1.0; color: __lightBackground ? Qt.rgba(1, 1, 1, 0.4) : Qt.rgba(1, 1, 1, 0.1) }
64 }64 }
65}65}
6666
=== added directory 'tests/resources/listitems'
=== added file 'tests/resources/listitems/Dividers.qml'
--- tests/resources/listitems/Dividers.qml 1970-01-01 00:00:00 +0000
+++ tests/resources/listitems/Dividers.qml 2014-10-24 15:04:57 +0000
@@ -0,0 +1,46 @@
1/*
2 * Copyright 2014 Canonical Ltd.
3 *
4 * This program is free software; you can redistribute it and/or modify
5 * it under the terms of the GNU Lesser General Public License as published by
6 * the Free Software Foundation; version 3.
7 *
8 * This program is distributed in the hope that it will be useful,
9 * but WITHOUT ANY WARRANTY; without even the implied warranty of
10 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 * GNU Lesser General Public License for more details.
12 *
13 * You should have received a copy of the GNU Lesser General Public License
14 * along with this program. If not, see <http://www.gnu.org/licenses/>.
15 */
16
17import QtQuick 2.0
18import Ubuntu.Components 0.1
19import Ubuntu.Components.ListItems 0.1
20import Ubuntu.Components.Popups 0.1
21
22MainView {
23 width: units.gu(50)
24 height: units.gu(100)
25
26 Component.onCompleted: Theme.name = "Ubuntu.Components.Themes.SuruDark"
27
28 Column {
29 width: parent.width
30 Repeater {
31 model: 5
32 Subtitled {
33 text: "Caption text"
34 subText: "Subtitle"
35 }
36 }
37 ThinDivider {}
38 Repeater {
39 model: 5
40 Subtitled {
41 text: "Caption text"
42 subText: "Subtitle"
43 }
44 }
45 }
46}

Subscribers

People subscribed via source and target branches