Code review comment for lp:~zsombi/ubuntu-ui-toolkit/textinputs-rightclick

Revision history for this message
Florian Boucault (fboucault) wrote :

> > > In the latest revision the selection is cleared when right-clicking
> outside
> > of
> > > the selected text
> > >
> > > 1. Select some text
> > > 2. Right-click somewhere in the unselected area
> > > 3. Should be able to cut the selected text
> >
> > One of the requirements in the bug was that right click must work in the
> same
> > way as the pressAndHold does. pressAndHold works in this way even in the
> > prerequisite.
>
> The bug literally says "right-click should trigger long press". It has no
> description at all. My best guess is that any menu you will trigger via long
> press should also be invoked via right-click. This is what I would expect. I'm
> doubtful it implies deviating from correct right-click behavior on GTK+ apps.
>
> The behavior is as it was in my last test run, so I'm afraid this is still
> wrong until we reach a conclusion.

Right click on desktop in QML/toolkit apps should behave like their GTK equivalent unless a strong case against it can be made.
I would even say that the long press on device should mimic what the right click does.

« Back to merge proposal