Code review comment for lp:~zsombi/ubuntu-ui-toolkit/textinputs-rightclick
Revision history for this message
| Zsombor Egri (zsombi) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> Selection is working indeed.
>
> - Multiple right-clicks still accumulate menus. I can see that it spans over
> different entries so I see how it's a Popover issue. Though to be honest it's
> a pretty serious bug.
It is a popover issue. Popovers get dismissed only on left-clicks. Right click do not have any effect on them. The same reason is that right clicks are not handled by a mouse area which does not accept right buttons.
It is a one-liner after all, but needs test cases, which makes it bigger and would be better to solve it in a separate MR rather than in this one. The question is whether we do it after this MR or before?
> - I can't get a menu if I right-click somewhere with no text - all the "Single
> line" entries in the gallery only work if you pay attention to aim at the text
> or respectively type something first and then click that.
The same happens with TextArea, if you right-click on the frame or on the gap between the frame and the text. The MouseArea that takes care of the frame does not handle/forward right clicks.