Code review comment for lp:~zsombi/ubuntu-ui-toolkit/textinput-carets

Revision history for this message
Zsombor Egri (zsombi) wrote :

> The carrots actually do a nice job on the desktop enabling me to extend
> selections with just a mouse - ordinarily it would require ⇧Arrow.
>
> A single carrot is visible when there's no selection but can't be dragged.

The single caret is just to grab the cursor for easy positioning of it. It's not a selection caret. The selection cares get visible when there is selected text.
>
> If the selection is at the very start of the text field the first carrot is
> clipped.

The carets are clipped in the input area atm, so the selection beginning will be clipped yet. I'll try to get a similar image above the actual one, but unfortunately positioning the overlay caret is not that stable... And may require changes in the logic...

>
> 505 - Ubuntu.Mouse.forwardTo: [inputHandler]
> 506 +// Ubuntu.Mouse.forwardTo: [inputHandler]
>
> Accident?

Yes, good catch!

>
> 526 +// FIXME: stabilize API
>
> What does this mean? Could you make the comment more verbose or mention a bug?

Means that the API will be moved in Ubuntu.Components.Styles. Once I get everything done, and in a separate MR perhaps.

« Back to merge proposal