Code review comment for lp:~zsombi/ubuntu-ui-toolkit/serviceproperties-component

Revision history for this message
Cris Dywan (kalikiana) wrote :

We need a test case for when accountservice is not available - if we don't want a hard dependency it can't be causing errors at runtime.

995 + QVERIFY(watcher->property("error").toString().isEmpty());
1009 + QVERIFY(watcher->property("error").toString().isEmpty());
1039 + QCOMPARE(errorSpy.count(), 0);

Please change all 3 cases where error is checked to a COMPARE so that the error becomes visible in the log.

785 - _CMD="./$_TARGET"
786 + _CMD="dbus-test-runner --task ./$_TARGET -n $_TESTFILE -m 30"

This must be 300 otherwise some tests time out.

review: Needs Fixing

« Back to merge proposal