Code review comment for lp:~zsombi/ubuntu-ui-toolkit/scrollbar-delegate-fix

Revision history for this message
Gerry Boland (gerboland) wrote :

+ var propContent = (vertical) ? "contentY" : "contentX";
You do this & similar in each function. It would be more elegant to have a object with a vertical property that is only changed when necessary, and private propOrigin, propContent and propPos vars based on that.

« Back to merge proposal