Ubuntu UI Toolkit

Code review comment for lp:~zsombi/ubuntu-ui-toolkit/qml-role-and-loader-removal

  1. qml-role-and-loader-removal
  2. Merge into trunk
Revision history for this message
Zsombor Egri (zsombi) wrote :

On 01/11/2013 01:55 PM, Tim Peeters wrote:
> // class name may have_QMLTYPE_XX or _QML_XX suffixes
> className = className.left(className.indexOf("_qml"));
> styleData.className = className;
> styleData.styleClass = className;
>
> Is this correct? It sets the classname to _qml. Shouldn't you use className.right?
 What do you mean it sets classname to _qml? Cuts off everything
starting from index of "_QML", so if a classname is
"ScrollBar_QMLTYPE_72" then the classname will be "scrollbar".

« Back to merge proposal