Code review comment for lp:~zsombi/ubuntu-ui-toolkit/pickerpanel
Revision history for this message
| Zsombor Egri (zsombi) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> 329 - QUrl baseUrl(const QStringList& importPathList, const char* uri);
> 330 + static QUrl baseUrl(const QStringList& importPathList, const char*
> uri);
>
>
> why is this needed?
It is needed for us to return the base path to the location of the Ubuntu Components library so we know where to search for the rest of the QML files to be used as sigleton types. This method was there before, all I did is I defined the function to be static, so it can be accessed in other singleton definition functions.
Btw, there's a comment in the body of the function, so we may get rid of this method once we go for Qt5.2, however as far as I see that method does a bit differently... Let's see.
> and shouldn't you add the static in the cpp as well?
Khmm... I pretend I have not seen this question... :) C++ basics...