Code review comment for lp:~zsombi/ubuntu-ui-toolkit/pickerpanel

Revision history for this message
Zsombor Egri (zsombi) wrote :

> 155 + function openPopover(caller, params) {
> 156 + var panel = PopupUtils.open(datePickerPopover, caller, params);
> 157 + panel.parent = QuickUtils.rootItem(null);
> 158 + return panel;
> 159 + }
>
> the name of the variable is a bit misleading here

I don't get it. Why? It can be a popover or an OSK panel... In a sense Popover is also a panel... and panel is also a popover... would you like to see popup there? OK, I'll rename to popover, but just for you :)

« Back to merge proposal