Code review comment for lp:~zsombi/ubuntu-ui-toolkit/pickerpanel

> 150 + property bool formFactorPhone: Screen.width <= units.gu(40) &&
> Screen.height <= units.gu(71)
>
> Do we always have Screen.height >= Screen.width ? What if width = 80, height =
> 50?
>
> 151 + // present in a property so we can test it in
> 152 + property bool isPhone: false
>
> Is there a design spec that says it should be done like this?
> What about a tiny tablet (like ipod touch)?

You are right in a sense that we have w/h 40/71 or h/w 40/71, due to landscape. And then we still need to show the picker in OSK area.
We don't have design spec, the wiki was the only thing we followed at some extent. I hate to say, but this whole component was really a mess from UX point of view. So all we have here is based on the UX guys, and they said they will return back once they have time to check it. So we will most probably have some updates later on this, Jouni promised to take a look at some point when the storm goes down. OSK area is a must, that's for sure, the Popover was suggested by me on higher FFs like tablet, desktop, TV, aso. He agreed that it is good to have it in such a way, let's see how we proceed with that.

iPod touch is NOT a tablet, Tim, sorry to disappoint you :)