Code review comment for lp:~zsombi/ubuntu-ui-toolkit/pickerpanel

Revision history for this message
Tim Peeters (tpeeters) wrote :

478 + function test_1_modeSet_YM() {
495 + function test_1_modeSet_YD() {
513 + function test_1_modeSet_HMS() {
530 + function test_1_modeSet_HS() {

You can combine these in one function with mode, pickerChildrenLength, modeIsValid parameters.

571 + function test_3_modeSet_YM() {
588 + function test_3_modeSet_YD() {
606 + function test_3_modeSet_HMS() {
623 + function test_3_modeSet_HS() {

same here

review: Needs Fixing

« Back to merge proposal