Code review comment for lp:~zsombi/ubuntu-ui-toolkit/pickerpanel
Revision history for this message
| Tim Peeters (tpeeters) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
150 + property bool formFactorPhone: Screen.width <= units.gu(40) && Screen.height <= units.gu(71)
Do we always have Screen.height >= Screen.width ? What if width = 80, height = 50?
151 + // present in a property so we can test it in
152 + property bool isPhone: false
Is there a design spec that says it should be done like this?
What about a tiny tablet (like ipod touch)?