Code review comment for lp:~zsombi/ubuntu-ui-toolkit/other-vibrations
Revision history for this message
| Zsombor Egri (zsombi) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> 64 +#define DYNAMIC_PROPERTY "__q_proeprty"
> 81 + // crear all previous connections
> 914 + property bool thisIsAndInvali
>
> Typos.
Ups... I should have an ibus filter which fixes proeprty, teh and si (is) typos :D
>
> Also, can we test with valid *and* invalid? To make sure the error won't be
> overridden by the valid one. From the code it doesn't seem to stop the loop in
> that case at least.
Yes, I will add one. The error will not be cleared ever if there was an error set. So a valid property won't clear the previous invalid property reported.