Code review comment for lp:~zsombi/ubuntu-ui-toolkit/ima-in-window

> 83 var popupObject;
> 84 if (params !== undefined) {
> 85 - popupObject = popupComponent.createObject(QuickUtils.rootObject,
> params);
> 86 + popupObject =
> popupComponent.createObject(QuickUtils.rootItem(popup), params);
> 87 } else {
> 88 - popupObject = popupComponent.createObject(QuickUtils.rootObject);
> 89 + popupObject =
> popupComponent.createObject(QuickUtils.rootItem(popup));
> 90 }
>
>
> popup can be a string. I think that will fail. Perhaps you need to use
> popupComponent here?
> Please test this (our old popup demo may be added to tests/resources).

Fixed in rev. 520