Code review comment for lp:~zsombi/ubuntu-ui-toolkit/ima-in-window

Revision history for this message
Zsombor Egri (zsombi) wrote :

> 169 + while (parentItem) {
> 170 + if (!parentItem->parentItem()) {
> ...
> }
>
> That could be written as
> while (parentItem->parentItem() {
> parentItem = parentItem->parentItem();
> }
>
> // ! parentIem->parentItem()
>
> lookupQuickView();
> 77 + if (m_rootView && (m_rootView->contentItem() == parentItem)) {
> 178 + return m_rootView->rootObject();
> 179 + } else {
> 180 + return parentItem;
> 181 + }
> 182 + }
> 183 + parentItem = parentItem->parentItem();
> 184 + }
> 185 + }
> 186 + return 0;

fixed in rev 519

« Back to merge proposal