Code review comment for lp:~zsombi/ubuntu-ui-toolkit/ima-in-window

Revision history for this message
Olivier Tilloy (osomon) wrote :

> Yes, true, but we don't necessarily have to walk the visual items only, as if
> we do, the Window won't be listed as a visual item. More, in case we have a
> Window, we need it's contentItem. And this is the way we can get it.

So what about walking up the hierarchy of (visual) parent items, and when reaching the top level visual item, try to get the non-visual parent and check whether it’s a QQuickWindow?

Also, is QuickUtils::rootItem(…) meant to work for non visual elements? If not, its parameter should be of type QQuickItem*.

« Back to merge proposal