Code review comment for lp:~zsombi/ubuntu-ui-toolkit/focus-handling-on-touch

Revision history for this message
Cris Dywan (kalikiana) wrote :

> > 214 + if (typeof window != "undefined") {
> >
> > This is still racy, it won't set if the window is available later. And it's
> > the third instance where this came up and wasn't handled correctly on the
> > first attempt.
> >
> > We need something like Context.onWindowAvailable and fix this consistently.
>
> I'll do a local fix with a property in between, and we can return to it in a
> separate MR with a proper fix.

Ack.

review: Approve

« Back to merge proposal