Code review comment for lp:~zsombi/ubuntu-ui-toolkit/fixTouchAdaptor

> Is the XCB 1.9.3 struct ABI specific to Qt's use or XCB itself? Is there any
> way to check that it's correct, either by Debian dependencies, or compile
> guards? Or some uni test that sanity-checks the value? Or a warning if the
> struct looks funny? Maybe there's no good way to handle this, just thinking
> out loud here.

That's a good question, I haven't seen any version check in Unity8 either... would be good though if we could at least guard the package...

>
> Also it seems redundant to issue "MouseTouchAdaptor not available on this
> architecture" in setEnabled when it's always issued from registerTouchDevices
> regardless of the platform guards. A test case for this would seem useful also
> because despite "indirect" test coverage immediate failures would be much
> clearer than unexpected funny results.
> Maybe even remove the touchDevices() function from the launcher to avoid
> false-positives because we have duplicate checks of the touch device? Though
> that last one could also be a separate mini MR.

I was thinking to flag out completely the use of the MouseTouchAdaptor, but then QML code would fail if the API would not be available on certain architectures... However as long as we keep X11 tests separate from the rest, those will not run on ARM....