Merge lp:~zsombi/ubuntu-ui-toolkit/fixAplColumnDivider into lp:ubuntu-ui-toolkit/staging

Proposed by Zsombor Egri
Status: Merged
Approved by: Tim Peeters
Approved revision: 1964
Merged at revision: 1975
Proposed branch: lp:~zsombi/ubuntu-ui-toolkit/fixAplColumnDivider
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 51 lines (+4/-6)
2 files modified
src/Ubuntu/Components/1.3/AdaptivePageLayout.qml (+4/-3)
src/Ubuntu/Components/plugin/uclistitem.cpp (+0/-3)
To merge this branch: bzr merge lp:~zsombi/ubuntu-ui-toolkit/fixAplColumnDivider
Reviewer Review Type Date Requested Status
ubuntu-sdk-build-bot continuous-integration Approve
Tim Peeters Approve
Review via email: mp+293058@code.launchpad.net

Commit message

AdaptivePageLayout vertical divider occludes with ListItem's visuals.

Description of the change

AdaptivePageLayout vertical divider occludes with ListItem's visuals.

To post a comment you must log in.
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Tim Peeters (tpeeters) wrote :

CI has failures on tst_adaptivepagelayout

http://pastebin.ubuntu.com/16093320/ shows the relevant part. It says 1 failure, but I don't see which one failed :s

1962. By Zsombor Egri

divider hides based on the column count

1963. By Zsombor Egri

staging sync

Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
1964. By Zsombor Egri

staging sync

Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Tim Peeters (tpeeters) wrote :

Looks good. Thanks.

review: Approve
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/Ubuntu/Components/1.3/AdaptivePageLayout.qml'
--- src/Ubuntu/Components/1.3/AdaptivePageLayout.qml 2016-03-16 09:15:39 +0000
+++ src/Ubuntu/Components/1.3/AdaptivePageLayout.qml 2016-05-10 07:10:08 +0000
@@ -788,7 +788,7 @@
788 bottom: parent.bottom788 bottom: parent.bottom
789 left: parent.left789 left: parent.left
790 right: parent.right790 right: parent.right
791 rightMargin: dividerThickness791 rightMargin: dividerThickness + verticalDivider.width
792 }792 }
793 Item {793 Item {
794 id: hiddenItem794 id: hiddenItem
@@ -806,6 +806,7 @@
806 left: parent.left806 left: parent.left
807 top: parent.top807 top: parent.top
808 right: parent.right808 right: parent.right
809 rightMargin: dividerThickness + verticalDivider.width
809 }810 }
810 height: body.headerHeight811 height: body.headerHeight
811812
@@ -856,7 +857,7 @@
856 right: parent.right857 right: parent.right
857 rightMargin: dividerThickness858 rightMargin: dividerThickness
858 }859 }
859 width: (column == (d.columns - 1)) || !pageWrapper ? 0 : units.dp(1)860 width: (column == (d.columns - 1)) ? 0 : units.dp(1)
860 color: theme.palette.normal.base861 color: theme.palette.normal.base
861 MouseArea {862 MouseArea {
862 id: resizerSensing863 id: resizerSensing
@@ -923,7 +924,7 @@
923 wrapper.active = false;924 wrapper.active = false;
924 subHeader.config = null;925 subHeader.config = null;
925 pageWrapper = null;926 pageWrapper = null;
926 wrapper.parent = hiddenPool;927 wrapper.parent = hiddenItem;
927 wrapper.pageHolder = null;928 wrapper.pageHolder = null;
928 return wrapper;929 return wrapper;
929 }930 }
930931
=== modified file 'src/Ubuntu/Components/plugin/uclistitem.cpp'
--- src/Ubuntu/Components/plugin/uclistitem.cpp 2016-04-26 10:21:32 +0000
+++ src/Ubuntu/Components/plugin/uclistitem.cpp 2016-05-10 07:10:08 +0000
@@ -1140,9 +1140,6 @@
1140 updateNode = true;1140 updateNode = true;
1141 }1141 }
1142 QRectF rect(boundingRect());1142 QRectF rect(boundingRect());
1143 // FIXME: The 1dp margin is here so that part of the focus frame
1144 // is not hidden by the APL divider. See bug #1575060.
1145 rect -= QMarginsF(0, 0, UCUnits::instance()->dp(1), 0);
1146 d->divider->setOpacity(paintFocus ? 0.0 : 1.0);1143 d->divider->setOpacity(paintFocus ? 0.0 : 1.0);
1147 rectNode->setRect(rect);1144 rectNode->setRect(rect);
11481145

Subscribers

People subscribed via source and target branches