Merge lp:~zsombi/ubuntu-ui-toolkit/fix-qmlapicheck into lp:ubuntu-ui-toolkit/staging

Proposed by Zsombor Egri
Status: Merged
Approved by: Zoltan Balogh
Approved revision: 1239
Merged at revision: 1240
Proposed branch: lp:~zsombi/ubuntu-ui-toolkit/fix-qmlapicheck
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 36 lines (+2/-13)
2 files modified
components.api (+0/-11)
tests/qmlapicheck.sh (+2/-2)
To merge this branch: bzr merge lp:~zsombi/ubuntu-ui-toolkit/fix-qmlapicheck
Reviewer Review Type Date Requested Status
Ubuntu SDK team Pending
Review via email: mp+233458@code.launchpad.net

Commit message

Exclude UbuntuColors dumped erroneously by qmlplugindump as it would be a C++ type.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'components.api'
--- components.api 2014-09-03 12:12:50 +0000
+++ components.api 2014-09-05 05:51:30 +0000
@@ -934,17 +934,6 @@
934 Parameter { name: "singular"; type: "string" }934 Parameter { name: "singular"; type: "string" }
935 Parameter { name: "plural"; type: "string" }935 Parameter { name: "plural"; type: "string" }
936 Parameter { name: "n"; type: "int" }936 Parameter { name: "n"; type: "int" }
937 prototype: "QObject"
938 name: "UbuntuColors"
939 exports: ["UbuntuColors -1.-1"]
940 Property { name: "orange"; type: "QColor"; isReadonly: true }
941 Property { name: "lightAubergine"; type: "QColor"; isReadonly: true }
942 Property { name: "midAubergine"; type: "QColor"; isReadonly: true }
943 Property { name: "darkAubergine"; type: "QColor"; isReadonly: true }
944 Property { name: "warmGrey"; type: "QColor"; isReadonly: true }
945 Property { name: "coolGrey"; type: "QColor"; isReadonly: true }
946 Property { name: "orangeGradient"; type: "QQuickGradient"; isPointer: true }
947 Property { name: "greyGradient"; type: "QQuickGradient"; isPointer: true }
948 name: "ULConditionalLayout"937 name: "ULConditionalLayout"
949 prototype: "QObject"938 prototype: "QObject"
950 exports: ["ConditionalLayout 0.1", "ConditionalLayout 1.0"]939 exports: ["ConditionalLayout 0.1", "ConditionalLayout 1.0"]
951940
=== modified file 'tests/qmlapicheck.sh'
--- tests/qmlapicheck.sh 2014-09-03 08:17:24 +0000
+++ tests/qmlapicheck.sh 2014-09-05 05:51:30 +0000
@@ -31,8 +31,8 @@
31test $ERRORS = 1 && echo Error: qmlplugindump failed && exit 131test $ERRORS = 1 && echo Error: qmlplugindump failed && exit 1
3232
33echo Running QML API check for $QML33echo Running QML API check for $QML
34# Palette gets included in Qt 5.2 qmlplugindump even though it's qml34# Palette and UbuntuColors gets included in Qt > 5.2 qmlplugindump even though it's qml
35BUILTINS=QQuick,QQml,U1db::,Palette python3 tests/qmlapicheck.py $QML plugins.qmltypes > components.api.new35BUILTINS=QQuick,QQml,U1db::,Palette,UbuntuColors python3 tests/qmlapicheck.py $QML plugins.qmltypes > components.api.new
36test $? != 0 && echo Error: qmlapicheck.py failed && exit 136test $? != 0 && echo Error: qmlapicheck.py failed && exit 1
3737
38echo Verifying the diff between existing and generated API38echo Verifying the diff between existing and generated API

Subscribers

People subscribed via source and target branches