Ubuntu UI Toolkit

Code review comment for lp:~zsombi/ubuntu-ui-toolkit/fix-import-versions

  1. fix-import-versions
  2. Merge into staging
Revision history for this message
Zsombor Egri (zsombi) wrote :

> 247 qputenv("QML2_IMPORT_PATH", "/no/plugins/here:.");
> 247 qputenv("QML2_IMPORT_PATH", "/no/plugins/here:./themes");
>
> 255 qputenv("UBUNTU_UI_TOOLKIT_THEMES_PATH", ".");
> 255 qputenv("UBUNTU_UI_TOOLKIT_THEMES_PATH", "./themes");
>
> This seems wrong. These tests ensure that themes are loaded without any
> defined variables, ie. all packaged click apps run that way. By passing the
> custom themes folder we no longer test that.

There was a problem that there was the TestModule.TestTheme folder which was in conflict with the shared theme under themes. I thought that was a mistake, but seems not - I copied these tests from the old theming, and back then there was no problems as there was no need for versioning support, which would have had to differentiate the shared and app themes. Now we have.

OTOH, the theming was always running so that having UBUNTU_UI_TOOLKIT_THEMES_PATH set will override XDG_DATA_DIRS and will add whatever path you have to the shared theme lookup paths. So, setting a value of "." actually does affect the theme loading and overrides whatever you have in XDG_DATA_DIRS. I guess that was the intention, otherwise the test is wrong.

I will get the removed app theme back with a different name so we have the test back.

« Back to merge proposal