Code review comment for lp:~zsombi/ubuntu-ui-toolkit/fix-import-versions

Revision history for this message
Cris Dywan (kalikiana) wrote :

247 qputenv("QML2_IMPORT_PATH", "/no/plugins/here:.");
247 qputenv("QML2_IMPORT_PATH", "/no/plugins/here:./themes");

255 qputenv("UBUNTU_UI_TOOLKIT_THEMES_PATH", ".");
255 qputenv("UBUNTU_UI_TOOLKIT_THEMES_PATH", "./themes");

This seems wrong. These tests ensure that themes are loaded without any defined variables, ie. all packaged click apps run that way. By passing the custom themes folder we no longer test that.

« Back to merge proposal